Cumulative layout credits

[zvi]

Title:
Cumulative layout credits

Area:
styles

Summary:
Currently, the layout credit module displays the credit from the lowest layer in the tree where it is coded, typically the theme layer. The layout credit module should add up the credit from all of the layers.

Description:
When one picks a style from the select style page, you are choosing two things at once, a layout layer and a theme layer. For most DW styles so far, a theme layer is a color scheme and maybe a header graphic. The layout layer does more to control the, er, shape of elements.

The way the layout credit module currently works, the credit displays the credit info from the lowest layer in the style, usually the theme/color scheme, but, presumably, it would take it from the user layer if one wrote one there.

This means that people who ought to be getting credit aren't getting it, even though there is code written to credit them.

The main drawback is that I think this might require re-working inheritance in S2 in a way that is bad for just about everything else one might do in S2.

The alternate way to do it might just be to write in the layout layer creator's name when adding theme layers to the official styles. (The drawback to this method is that it is a social hack, instead of a code hack.)

Poll #1155 Cumulative layout credits

Open to: Registered Users, detailed results viewable to: All, participants: 27

View Respondents

This suggestion:

View Answers

Should be implemented as-is.
14 (51.9%)

Should be implemented with changes. (please comment)
4 (14.8%)

Shouldn't be implemented.
0 (0.0%)

(I have no opinion)
9 (33.3%)

(Other: please comment)
0 (0.0%)

Comments

[yvi]

The main drawback is that I think this might require re-working inheritance in S2 in a way that is bad for just about everything else one might do in S2.

I don't think that's necessary. We could have one variable style_credit which is defined in layout.s2 and one variable theme_credit which is defined for each theme in themes.s2 and display both if both exist, or just the style_credit if both are the same / there is no theme_credit.

Edit: We could also then have people be able to override theme_credit (if that's possible), so they can add credit to whoever wrote the custom CSS they are using - we have had at least one support request about wanting to add credit into that module.

[afuna]

The layout_credit variable can already take multiple author names; I don't know if it's better to put everything in there, or separate them into "Layout" versus "Theme".

[zvi]

I personally think it would be better to put them all together, as I'd prefer to keep the set up as compact as possible.

[turlough]

Yeah, me too.

[zvi]

To clarify, when I say put them all together, I think it would be best for the default stylesheet to display Layout Credit and Theme Credit in the same div.module, even if the names themselves wind up in two separate uls or two separate divs or howsoever, so theme writers can further manipulate it. But I'd like the default HTML/CSS to favor compact presentation.

[kaigou]

+1

[zvi]

Yes, adding credit for custom css would be quite nice.

[turlough]

Oh yes!

[ninetydegrees]

I'd rather have layout_credit rewritten in the theme to include the layout author's name.

[zvi]

Why?

[ninetydegrees]

Because I like the way inheritance currently works fine. The property can be edited. Why not do that?

[zvi]

Well, for one thing, the layout author is often not the theme author, so you'd be putting false info into the theme layer.

For another, yvi has thought of a way to do this which doesn't require screwing with inheritance generally.

[ninetydegrees]

I don't see it like this.

I hadn't read this comment. Sure, another property would work too.