codeman38: Image of a Shy Guy and several Hothead enemies from Super Mario, with the caption 'A shy guy in a world of hotheads'. (Default)
Cody B. ([personal profile] codeman38) wrote in [site community profile] dw_suggestions2010-10-21 09:54 am

Expanding messages in Inbox broken in several ways

Title:
Expanding messages in Inbox broken in several ways

Area:
Inbox

Summary:
To view messages that have already been read in your Inbox, it's necessary to click on a small (11x11 pixel) triangle. There are several issues with the implementation of this.

Description:
In Dreamwidth's inbox system, posts which have already been read are hidden from view and must be manually expanded. This makes perfect sense; there's no reason to see stuff that you haven't read already.

However, the way that expanding these messages is implemented is problematic in several ways.

First of all, the size of the target is ridiculously small: 11x11 pixels. And as far as I can tell, the little arrow is the only way to expand these messages; clicking on the message itself checks the checkbox for that message rather than expanding it. It seems to me that there should be a much larger target for viewing the message rather than checking it, or some other behavior to view the message (double- rather than single-click, for instance).

Second, because this JavaScript is implemented solely using the 'click' event, it is keyboard-inaccessible. There should be a listener for 'keyDown' as well.

Third, the behavior breaks completely if JavaScript is turned off. The non-JavaScript link for the 'expand' button goes back to the main Inbox page, even if you're on a subpage. And even if the Inbox page is selected, the link doesn't actually do anything to collapse/expand the comment! This, at the very least, *definitely* needs to be fixed-- it should be possible to view messages without JavaScript turned on. (As a side effect, it would also fix keyboard accessibility until a keyDown listener was added.)

Poll #4945 Expanding messages in Inbox broken in several ways
Open to: Registered Users, detailed results viewable to: All, participants: 43


This suggestion:

View Answers

Should be implemented as-is.
32 (74.4%)

Should be implemented with changes. (please comment)
2 (4.7%)

Shouldn't be implemented.
0 (0.0%)

(I have no opinion)
9 (20.9%)

(Other: please comment)
0 (0.0%)

thorfinn: <user name="seedy_girl"> and <user name="thorfinn"> (Default)

[personal profile] thorfinn 2010-11-01 06:28 am (UTC)(link)
That's the general expandable cut tag thing, I think? I actually do have a bit of an issue with the size of that icon in all contexts - it's quite hard to hit it, especially on an iPhone, but I imagine the same issue applies to most mobile devices.
kerravonsen: (Default)

[personal profile] kerravonsen 2010-11-01 11:18 am (UTC)(link)
No, it's talking about messages, not cut-tags. But, yes, in both cases the icon is very small and hard to click on.
thorfinn: <user name="seedy_girl"> and <user name="thorfinn"> (Default)

[personal profile] thorfinn 2010-11-01 11:55 pm (UTC)(link)
I see. Well, I guess my with changes is to have the icon size increased on cut tags too. :-)

[personal profile] feathertail 2010-11-02 03:34 am (UTC)(link)
I agree, definitely.
0jack: Closeup of Boba Fett's helmet, angular orange stripe surrounding a narrow window on a greenish metallic field. (Default)

[personal profile] 0jack 2010-11-01 02:15 pm (UTC)(link)
Absolutely agree. It would also be nifty to have a option box to expand all or expand all unread. But, the most important thing is to eliminate any features that aren't accessible. I'm relatively able-bodied and it is hard for me to click on the triangle. Also, it took me forever to figure out what the triangle did. :p It has to be clearer and available from the keyboard.