branchandroot: oak against sky (Default)
Branch ([personal profile] branchandroot) wrote in [site community profile] dw_suggestions2010-09-08 03:19 pm

Name Layout designer as well as Theme designer in Layout Credit module

Title:
Name Layout designer as well as Theme designer in Layout Credit module

Area:
styles

Summary:
At the moment, the Layout Credit module shows the name of the person who made the theme, but not the name of the person who made the layout itself (unless they happen to be the same person). It should show both.

Description:
Background: Settings made in a theme layer override those in the layout layer. This means that, because a theme currently only sets the name of its own author in the layout_authors variable, the name of the layout designer (set in the layout layer) is overridden and erased by the theme setting.

Solution: The easiest way to fix this is to make sure that all theme layers have the layout author's name set, as well as the theme author's, so that both will appear in the Layout Credit module.

Extra Spiffy Solution: Extra refinements might involve tinkering with the layout_authors array and the print_module_credit function to add another variable--one for what kind of author the designer named is. For example:

set layout_authors = [ { "name" => "jane_user", "type" => "user", "role" => "layout" },
{ "name" => "joe_user", "type" => "user", "role" => "theme" } ];

And when those are rendered into links, if there is no "role" filled in then the label for that author defaults to text_layout_authors, which could maybe be set to something more neutral or encompassing like "Designer"; if "role" is filled in, then instead of "Designer" the label would be "Layout" or "Theme", as appropriate.

If the suggestion that the layout and/or theme name be shown in the credit module is adopted, then the labels "Layout" and "Theme" could each be linked to the appropriate page of the "Select Style" area.

Poll #4414 Name Layout designer as well as Theme designer in Layout Credit module
Open to: Registered Users, detailed results viewable to: All, participants: 28


This suggestion:

View Answers

Should be implemented as-is.
23 (82.1%)

Should be implemented with changes. (please comment)
0 (0.0%)

Shouldn't be implemented.
0 (0.0%)

(I have no opinion)
5 (17.9%)

(Other: please comment)
0 (0.0%)

ninetydegrees: Drawing: a girl's face, with a yellow and green stripe over one eye (Default)

[personal profile] ninetydegrees 2010-09-17 04:16 am (UTC)(link)
@ the admins: already suggested (http://dw-suggestions.dreamwidth.org/94863.html) and migrated (http://bugs.dwscoalition.org/show_bug.cgi?id=1845). This has also been re-suggested quite recently but I can't remember when.
denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)

[staff profile] denise 2010-09-17 04:21 am (UTC)(link)
Yeah, I let it through because (to the best of my knowledge, not knowing much about styles) this has different and useful implemenation notes, and I will combine the two when I get to this post in the dispatching.
ninetydegrees: Drawing: a girl's face, with a yellow and green stripe over one eye (Default)

[personal profile] ninetydegrees 2010-09-17 04:22 am (UTC)(link)
Oh sure. I've actually made a patch for this quite a while ago, though.
zvi: self-portrait: short, fat, black dyke in bunny slippers (Default)

[personal profile] zvi 2010-09-17 04:39 am (UTC)(link)
Duplicate of bug 1845
Edited (quotation marks, damn them) 2010-09-17 04:40 (UTC)