mm_writes: Sheep go to heaven, goats go to hell (Default)
Where Agglutinations Abound ([personal profile] mm_writes) wrote in [site community profile] dw_suggestions2013-08-20 10:00 pm

Add a CSS Class to Comment Count on View Month Page

Title:
Add a CSS Class to Comment Count on View Month Page

Area:
styles

Summary:
Right now there is no CSS class for the comment count shown after each post on the View Month Page (this page and all pages like it): http://exampleusername.dreamwidth.org/2013/01/. I've had to add sort of wonky CSS to compensate for that. The CSS doesn't target anything specific so in my case it messes things up (for instance, on my DW, it results in comment count text displaying both too small and too big - yes, all at the same time - which could be my own error, but still). So my suggestion is to simply add a separate span class for the comment count on the View Month page so it can be styled independently of other elements on the page.

Description:
Right now there is no CSS class for the comment count shown after each post on the View Month Page (this page and all pages like it): http://exampleusername.dreamwidth.org/2013/01/. I've had to add sort of wonky CSS to compensate for that. The CSS doesn't target anything specific so it messes things up (for instance, on my DW, it results in comment count text displaying both too small and too big - yes, all at the same time - which could be my own error, but still). My suggestion is to simply add a separate span class for the comment count on the View Month page so it can be styled precisely and independently of other elements.

Poll #14590 Add a CSS Class to Comment Count on View Month Page
Open to: Registered Users, detailed results viewable to: All, participants: 33


This suggestion:

View Answers

Should be implemented as-is.
17 (51.5%)

Should be implemented with changes. (please comment)
2 (6.1%)

Shouldn't be implemented.
1 (3.0%)

(I have no opinion)
13 (39.4%)

(Other: please comment)
0 (0.0%)

carene_waterman: An image of the Carina Nebula (Default)

[personal profile] carene_waterman 2013-11-27 04:38 pm (UTC)(link)
Before you can add an HTML class to be used by the CSS, you have to have some HTML.

Right now the comment count on these pages is unenclosed text within a dd element that contains various spans, links and headings, followed by a br tag.

I would suggest it be enclosed in p tags, since the desired effect would seem to be a block level element, with a class that can be used for all counts of things like entries, comments or tags.

But this brings up the larger issue of all the other places where the site is built with unenclosed text--the tag counts in the sidebar and tag pages, for example.

Is this good practice or not?
carene_waterman: An image of the Carina Nebula (Default)

[personal profile] carene_waterman 2013-11-28 02:45 pm (UTC)(link)
A span may be more correct since the text is part of some sort of element in all cases, and a generic tag primarily for styling is enough.

But I noticed looking at this again that each entry on a particular day is not in its own dd, which it should be.

The whole page would make more semantic sense if each entry was separately enclosed.

I have no idea what .echi is or what you're trying to say there, sorry.